RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

[Mingarelli, Thomas]

I am OK with the changes. We have a few more coming soon to improve the kdump process when hpwdt is running. Just a heads up.


Thanks,
Tom

-----Original Message-----
From: wimvs@xxxxxxxxxxxxxxxxxxx [mailto:wimvs@xxxxxxxxxxxxxxxxxxx] On Behalf Of Wim Van Sebroeck
Sent: Wednesday, August 22, 2012 2:25 PM
To: Andi Kleen
Cc: linux-kernel@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; mmarek@xxxxxxx; linux-kbuild@xxxxxxxxxxxxxxx; JBeulich@xxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; Andi Kleen; Mingarelli, Thomas
Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

Hi andi,

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> We cannot assume that the inline assembler code always ends up
> in the same file as the original C file. So make any assembler labels
> that are called with "extern" by C global
> 
> Cc: wim@xxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

You have my signed-off-by, but I'm Cc-ing also the author of the driver
(Tom Mingarelli) so that he is also aware of the proposed change.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/