Re: [PATCH] ARM: Fix XIP build due to PHYS_OFFSET definition moving

[Stephen Boyd]

On 08/09/12 23:46, Stephen Boyd wrote:
> On 8/2/2012 6:23 PM, Stephen Boyd wrote:
>> During the p2v changes, the PHYS_OFFSET #define moved into a
>> !__ASSEMBLY__ section. This causes a XIP build to fail with
>>
>>  arch/arm/kernel/head.o: In function 'stext':
>>  arch/arm/kernel/head.S:146: undefined reference to 'PHYS_OFFSET'
>>
>> Momentarily leave the #ifndef __ASSEMBLY__ section so we can
>> define PHYS_OFFSET for all compilation units.
>>
>> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>> ---
>>
>> I don't know if it's worth stable, seems that nobody has compiled XIP for
>> a year (back to 2.6.39 days?).
> Is this approach acceptable? Shall I put this in the patch tracker?
>

I'll take silence to mean "yes", so I'll put this in the patch tracker
unless someone objects.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/