RE: [PATCH v2] x86/vsmp: Use hypervisor layer for initialization

[Shai Fultheim (Shai@xxxxxxxxxxx)]

Ingo,

Use of vSMP Foundation does not require compiling with CONFIG_X86_VSMP, which is off by default in any distribution to date.

vsmp_64.c and is_vsmp_box() are depended on CONFIG_X86_64, and we will make sure to fix any deviation from the current situation.  We want very much to move to the new hypervisor API, but do not want to loose existing functionality that can hurt all our install base.

Let us go back and see if there is a cleaner way to fix this, while keeping the existing functionality.

Thanks for your understanding,
Shai.


--Shai 


> -----Original Message-----
> From: Ingo Molnar [mailto:mingo.kernel.org@xxxxxxxxx] On Behalf Of Ingo
> Molnar
> Sent: Wednesday, August 22, 2012 20:49
> To: Shai Fultheim (Shai@xxxxxxxxxxx)
> Cc: Ido Yariv; linux-kernel@xxxxxxxxxxxxxxx; Thomas Gleixner; H. Peter Anvin
> Subject: Re: [PATCH v2] x86/vsmp: Use hypervisor layer for initialization
> 
> 
> * Shai Fultheim (Shai@xxxxxxxxxxx) <Shai@xxxxxxxxxxx> wrote:
> 
> > Ingo,
> >
> > CONFIG_X86_VSMP is only for setting cache-line size to 4KB.
> > Rest of the bits were never depended on this.
> 
> That's a problem - please move vSMP functionality under a
> simple, properly named Kconfig toggle. Many of the build
> problems are related to that.
> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/