Re: [PATCH 1/2] mmc: core: Add a capability for disabling mmc cards

From: Philip Rakity
Date: Wed Aug 22 2012 - 12:00:59 EST



On Aug 22, 2012, at 8:44 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:

> Jaehoon,
>
> On Tue, Aug 21, 2012 at 9:35 PM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
>>
>> Hi Doug,
>>
>> I didn't know what purpose is.
>> Why need to add the MMC_CAP2_NO_MMC?
>> If card is SD or SDIO, mmc_attach_mmc(host) should not be entered.
>> Could you explain to me in more detail?
>
> Thanks for your feedback. In this case I have a card that is an MMC
> card so mmc_attach_sdio() and mmc_attach_sd() will fail. If I let
> mmc_attach_mmc() run it will actually find the MMC card. However, on
> this platform it is not valid to recognize MMC cards.
>


Understand.

Can you explain why the change is needed. Is it for technical
reasons that MMC is not allowed -- if so then I do not understand how SD can work
and MMC cannot.

If it is for marketing reasons -- then --- oh well .....


Could you add some additional comments to the commit message.
I think it makes sense to handle all 3 cases
a) SDIO not allowed
b) SD not allowed
c) MMC not allowed

> -Doug
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/