Re: [PATCH] [Signed-off] kconfig: document oldnoconfig to what itreally does in conf.c

From: Adam Lee
Date: Wed Aug 22 2012 - 09:45:40 EST


On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
> 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
> instead sets it to their default values.
>
> This patch fixes the document in conf.c, and will submit another patch
> to replace 'oldnoconfig' to 'olddefconfig'
>
> Signed-off-by: Adam Lee <adam8157@xxxxxxxxx>
> ---
> scripts/kconfig/conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

I think we should apply this patch, any comment?

I was confused by the different documents of `make help` and usage of
"scripts/kconfig/conf.c" before I got through conf.c and checked the git
log. Others maybe confused too. So I think we really should apply this
patch at least.

As regards whether that target should be renamed to 'olddefconfig', we
can discuss it at another thread.

Thank you.

--
Regards,
Adam Lee
http://adam8157.info
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/