Re: [tip:x86/platform] x86/vsmp: Use hypervisor layer forinitialization

[Ido Yariv]

Hi Ingo,

On Wed, Aug 22, 2012 at 11:11:41AM +0200, Ingo Molnar wrote:
> 
> * tip-bot for Ido Yariv <ido@xxxxxxxxxx> wrote:
> 
> > Commit-ID:  c00679af441c5be76e195deed2c76fef65a5d102
> > Gitweb:     http://git.kernel.org/tip/c00679af441c5be76e195deed2c76fef65a5d102
> > Author:     Ido Yariv <ido@xxxxxxxxxx>
> > AuthorDate: Wed, 8 Aug 2012 20:01:38 +0300
> > Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> > CommitDate: Wed, 22 Aug 2012 10:48:05 +0200
> > 
> > x86/vsmp: Use hypervisor layer for initialization
> > 
> > vSMP detection and initialization could be done by
> > the hypervisor layer, so set it up that way.
> > 
> > This cleans up vSMP initialization.
> > 
> > Signed-off-by: Ido Yariv <ido@xxxxxxxxxx>
> > Acked-by: Shai Fultheim <shai@xxxxxxxxxxx>
> > Link: http://lkml.kernel.org/r/1344445299-22142-1-git-send-email-ido@xxxxxxxxxx
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > ---
> >  arch/x86/include/asm/hypervisor.h |    1 +
> >  arch/x86/include/asm/setup.h      |    7 -------
> >  arch/x86/kernel/cpu/hypervisor.c  |    1 +
> >  arch/x86/kernel/setup.c           |    2 --
> >  arch/x86/kernel/vsmp_64.c         |   27 +++++++++++++++++----------
> >  5 files changed, 19 insertions(+), 19 deletions(-)
> 
> I had to zap this commit because it breaks the build:
> 
> (.init.rodata+0x4c8): undefined reference to `x86_hyper_vsmp'

I failed to notice that vsmp_64.c is only built on 64bit, so this will
break on 32bit builds.

How about the patch below?

Thanks,
Ido.