Re: [PATCH 04/10] staging: media: go7007: Add IDENT for TW2802/2804

[Hans Verkuil]

On Wed August 22 2012 12:45:13 Volokh Konstantin wrote:
> Signed-off-by: Volokh Konstantin <volokh84@xxxxxxxxx>
> ---
>  include/media/v4l2-chip-ident.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/media/v4l2-chip-ident.h b/include/media/v4l2-chip-ident.h
> index 7395c81..5395495 100644
> --- a/include/media/v4l2-chip-ident.h
> +++ b/include/media/v4l2-chip-ident.h
> @@ -113,6 +113,10 @@ enum {
>  	/* module vp27smpx: just ident 2700 */
>  	V4L2_IDENT_VP27SMPX = 2700,
>  
> +	/* module wis-tw2804: 2802/2804 */
> +	V4L2_IDENT_TW2802 = 2802,
> +	V4L2_IDENT_TW2804 = 2804,
> +
>  	/* module vpx3220: reserved range: 3210-3229 */
>  	V4L2_IDENT_VPX3214C = 3214,
>  	V4L2_IDENT_VPX3216B = 3216,
> 

There is no need to add this, unless the g/s_register or g_chip_ident ops
are also implemented.

In this case I'd just drop this patch.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/