Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support forvt8500-serial

[Alan Cox]

On Wed, 22 Aug 2012 08:47:32 +1200
Tony Prisk <linux@xxxxxxxxxxxxxxx> wrote:

> Signed-off-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/vt8500_serial.c |   37 ++++++++++++++++++++++++++++++++----
>  1 file changed, 33 insertions(+), 4 deletions(-)

Can we have a comment attached to a change this size. In particular one
describing why it gone from 4 to 6 ports, and why the port id twiddling.

Is there a reason you can't use the device tree port id ?

What are the regression risks for existing users expecting the pdev->id
binding ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/