Re: [PATCH] tun: don't zeroize sock->file on detach

[Stanislav Kinsbursky]

10.08.2012 03:16, David Miller ÐÐÑÐÑ:
> From: Stanislav Kinsbursky <skinsbursky@xxxxxxxxxxxxx>
> Date: Thu, 09 Aug 2012 16:50:40 +0400
>
> > This is a fix for bug, introduced in 3.4 kernel by commit
> > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced
> > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to
> > oops for non-persistent devices:
> >
> > tun_chr_close()
> > tun_detach()				<== tun->socket.file = NULL
> > tun_free_netdev()
> > sk_release_sock()
> > sock_release(sock->file == NULL)
> > iput(SOCK_INODE(sock))			<== dereference on NULL pointer
> >
> > This patch just removes zeroing of socket's file from __tun_detach().
> > sock_release() will do this.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reported-by: Ruan Zhijie <ruanzhijie@xxxxxxxxxxx>
> > Tested-by: Ruan Zhijie <ruanzhijie@xxxxxxxxxxx>
> > Acked-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Acked-by: Yuchung Cheng <ycheng@xxxxxxxxxx>
> > Signed-off-by: Stanislav Kinsbursky <skinsbursky@xxxxxxxxxxxxx>
>
> Applied, thanks.

Hi, David.
I found out, that this commit: b09e786bd1dd66418b69348cb110f3a64764626a
was previous attempt to fix the problem.
I believe this commit have to be dropped.


--
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/