Re: [RFC PATCH -v2 0/4] Persistent events

From: Steven Rostedt
Date: Tue Aug 21 2012 - 09:41:11 EST


On Tue, 2012-08-21 at 15:11 +0200, Borislav Petkov wrote:
> On Tue, Aug 21, 2012 at 12:30:50PM +0200, Peter Zijlstra wrote:
> > Good progress there, there's still a few things though:
> >
> > - the point also raised by Steven, I'm pretty sure that the placing of
> > the debugfs files unfortunate. I would much rather see something
> > like /debug/perf/persistent/$foo, also dropping your
> > perf_event_desc::dir_name.
>
> Ok, how do we want to do the per-CPU layout there? Like this:
>
> /debug/perf/persistent/mce_record0
> /debug/perf/persistent/mce_record1
> ...
>
> or rather
>
> /debug/perf/persistent/cpu0/mce_record
> /debug/perf/persistent/cpu1/mce_record
>
> ?

Definitely the second one. The first one is just ugly. The second is
more in line to the tracing directories too:

/debug/tracing/per_cpu/cpu0/...

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/