Re: [alsa-devel] [PATCH] snd-als100: fix suspend/resume

From: Takashi Iwai
Date: Tue Aug 21 2012 - 04:00:40 EST


At Mon, 20 Aug 2012 21:50:13 +0200,
Ondrej Zary wrote:
>
> snd_card_als100_probe() does not set pcm field in struct snd_sb.
> As a result, PCM is not suspended and applications don't know that they need
> to resume the playback.
>
> Tested with Labway A381-F20 card (ALS120).
>
> Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>

Applied now. Thanks.


Takashi

>
> --- a/sound/isa/als100.c
> +++ b/sound/isa/als100.c
> @@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
> irq[dev], dma8[dev], dma16[dev]);
> }
>
> - if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
> + if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
> snd_card_free(card);
> return error;
> }
>
>
>
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/