Re: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial diosubdevice state and io_bits

[Dan Carpenter]

On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
> +	if (this_board->n_diochan) {
> +		s = dev->subdevices + subdev;

This pointer math sucks still...  I feel like the unreadable code is
part of what caused this bug.

We don't have to change these all at once.  If we fix only one line,
then at least one line will be readable and that is one more than
before so *improvement*.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/