Re: [PATCH] regulator: max8907: fix compile error when !CONFIG_OF
From: Mark Brown
Date: Mon Aug 20 2012 - 15:57:52 EST
On Mon, Aug 20, 2012 at 09:39:10AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@xxxxxxxxxx>
>
> Fix the following:
Applied, thanks.
> Note: It's possible that the MAX8907 PMIC is only used with Tegra; there
> certainly is a reference to AP15 (an old Tegra version) in the MAX8907
> documentation. If so, Tegra implies CONFIG_OF, so we could just make
> MAX8907 depend on CONFIG_OF and remove all the ifdefs from the driver.
> That said, I'm not at all sure whether the MAX8907 is Tegra-specific.
I think this would be a step backwards, if it's that hard to make DT
optional we ought to look at the DT infrastructure. Otherwise build
coverage is good.
Attachment:
signature.asc
Description: Digital signature