Re: [RFC][PATCH v2 1/3] efivars: Disable external interrupt whileholding efivars->lock

From: Mike Waychison
Date: Mon Aug 20 2012 - 15:17:22 EST


Acked-by: Mike Waychison <mikew@xxxxxxxxxx>

> @@ -1101,11 +1107,12 @@ out_free:
> void unregister_efivars(struct efivars *efivars)
> {
> struct efivar_entry *entry, *n;
> + unsigned long flags;
>
> list_for_each_entry_safe(entry, n, &efivars->list, list) {
> - spin_lock(&efivars->lock);
> + spin_lock_irqsave(&efivars->lock, flags);
> list_del(&entry->list);
> - spin_unlock(&efivars->lock);
> + spin_unlock_irqrestore(&efivars->lock, flags);
> efivar_unregister(entry);
> }
> if (efivars->new_var)

Feel free to remove any other uses of flags where you know that you
are being called from process context.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/