RE: [PATCH 00/11] x86/microcode: Early load microcode

[Yu, Fenghua]

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@xxxxxxxxx]
> Sent: Monday, August 20, 2012 8:39 AM
> To: Yu, Fenghua
> Cc: H Peter Anvin; Ingo Molnar; Thomas Gleixner; Mallick, Asit K;
> Tigran Aivazian; Andreas Herrmann; Borislav Petkov; linux-kernel; x86
> Subject: Re: [PATCH 00/11] x86/microcode: Early load microcode
> 
> On Sat, Aug 18, 2012 at 01:15:18AM -0700, Fenghua Yu wrote:
> >  Documentation/x86/earlyucode.txt        |   43 +++
> >  arch/x86/Kconfig                        |   22 ++
> >  arch/x86/include/asm/cpio.h             |   10 +
> >  arch/x86/include/asm/microcode.h        |   23 ++
> >  arch/x86/include/asm/microcode_intel.h  |  103 +++++++
> >  arch/x86/kernel/Makefile                |    3 +
> >  arch/x86/kernel/head64.c                |    6 +
> >  arch/x86/kernel/head_32.S               |    6 +
> >  arch/x86/kernel/microcode_core.c        |    7 +-
> >  arch/x86/kernel/microcode_core_early.c  |   74 +++++
> >  arch/x86/kernel/microcode_intel.c       |  185 +------------
> >  arch/x86/kernel/microcode_intel_early.c |  482
> +++++++++++++++++++++++++++++++
> >  arch/x86/kernel/microcode_intel_lib.c   |  163 +++++++++++
> 
> One more thing:
> 
> This screams for adding a directory called "microcode" in the kernel
> sources and moving all the microcode-related files there. IOW:
> 
> arch/x86/kernel/cpu/microcode/core.c
> arch/x86/kernel/cpu/microcode/core_early.c
> arch/x86/kernel/cpu/microcode/intel.c
> arch/x86/kernel/cpu/microcode/amd.c
> ...
> 
> And yes, they should be under "cpu" too.

That's right.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/