Re: [PATCH] regulator: ab8500: fix voltage selector regression

From: Linus Walleij
Date: Mon Aug 20 2012 - 11:18:24 EST


On Mon, Aug 20, 2012 at 4:51 PM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> ? ??2012-08-20 ? 14:18 +0200?Linus Walleij ???
>> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
>> Commit 3bf6e90e476fb34ca47b6dda270f41d9cebcb1ac
>> "regulator: Convert ab8499 to use get_voltage_sel()"
>> and commit ae713d394d9e2aacaab620acd3212855f1f06b00
>> "regulator: Convert ab8500 to set_voltage_sel"
>> corrupted the voltage selector mechanism is two ways:
>
> I'm not very sure the commits you mentioned is the root cause,
> because it looks that here is no behavior change with both commits.
> Does it really work if you revert above commits you mention?

No you're right, I've screwed up completely... I confused
two codebases. I'll fix a proper patch adding the proper
voltage shift fields to the regulator info.

Sorry about this Axel!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/