Re: [patch 1/2]block: handle merged discard request

From: Mike Snitzer
Date: Mon Aug 20 2012 - 10:12:39 EST


On Mon, Aug 20 2012 at 9:58am -0400,
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Mon, Aug 20, 2012 at 09:57:39AM -0400, Mike Snitzer wrote:
> > But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec
> > (but given my use of DM, bio comes from bio_alloc_bioset, and DM passes
> > original bio->bi_max_vecs for nr_iovecs).
>
> TRIM has a payload and we cheay by preallocation a data page for it.

Thought we pushed that down? Hence sd_setup_discard_cmnd's
alloc_page + blk_add_request_payload hack.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/