Re: [PATCH] leds-lm3530: replace pwm platform functions with genericpwm functions

[Thierry Reding]

On Mon, Aug 20, 2012 at 06:16:41AM +0000, Kim, Milo wrote:
> > > * Rather than having to do the #ifdef here, I think it would be
> > better if
> > >   the PWM subsystem provided stub functions for pwm_request,
> > pwm_config,
> > >   pwm_enable, pwm_disable and pwm_free that do nothing, so you can in
> > effect
> > >   let the compiler optimize away the above code.
> > 
> > That's actually on my TODO list, but I think it needs to wait until we
> > have gotten rid of all legacy implementations. The stubs would have to
> > move into the !CONFIG_PWM branch, which will in turn break because the
> > legacy implementations would provide non-inlined duplicates.
> > 
> > Thierry
> 
> OK, then it's better to wait fixing that first.
> 
> Bryan,
> please just ignore this patch.
> I'll resend the patch later.

Maybe we should get this resolved somehow in the meantime. Resolving the
other issues may take another cycle or two, so you may not want to wait
that long.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature