RE: [PATCH] leds-lm3530: replace pwm platform functions withgeneric pwm functions

[Kim, Milo]

> In that case, I would recommend changing it from
> 
> +       /* if the pwm device exists, skip requesting the device */
> +       if (drvdata->pwm)
> +               return 0;
> 
> to
> 
> 	/* warn if the PWM was not released prior to reneabling it */
> 	WARN_ON(drvdata->pwm);
> 

OK, thanks for your comments!

Best Regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/