Re: [PATCH 01/31] Disable const sections for PA-RISC

[Sam Ravnborg]

On Sun, Aug 19, 2012 at 04:07:10AM +0200, Andi Kleen wrote:
> > > +config BROKEN_RODATA
> > > +	bool
> > > +	default y
> > 
> > Could you please change this so we have a commonly defined HAVE_BROKEN_RODATA
> > symbol. Then arch's that have broken RO data can select this symbol.
> > If we experience tomorrow that sparc have the same issue then with
> > this patch sparc has to create a local definition of this symbol.
> 
> Here's an updated patch with the config placed in init/Kconfig.

Looks good!

> I'm not going to repost the whole series.
> 
> -Andi
> 
> ---
> 
> Disable const sections for PA-RISC v2
> 
> The PA-RISC tool chain seems to have some problem with correct read/write
> attributes on sections. This causes problems when the const sections
> are fixed up for other architecture to only contain truly read-only
> data.
> 
> Disable const sections for PA-RISC
> 
> This can cause a bit of noise with modpost.
> 
> v2: Move config to init/Kconfig
> Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/