Re: [PATCH 3/8] ext3: remove lock/unlock super

[Marco Stornelli]

Il 16/08/2012 21:19, Theodore Ts'o ha scritto:
> On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote:
> > On Thu 16-08-12 12:00:26, Marco Stornelli wrote:
> > > From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> > >
> > > Replaced lock and unlock super with a new fs mutex s_lock.
> >    Hum, is the lock needed at all? Remount & unfreeze both run with s_umount
> > held for writing. Thus we already have exclusion between these two calls.
> > The same seems to hold for ext4 BTW.
>
> Agreed, it's not clear lock_super() is needed at all for ext4 at this
> point.
>
> 	     	       		       	      - Ted

Great. I'll remove the calls for ext3/ext4 when I'll submit the second 
version of the patch.

Thanks for your feedback,

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/