Re: [NEW DRIVER V3 1/8] DA9058 MFD core driver

From: Mark Brown
Date: Thu Aug 16 2012 - 08:45:44 EST


On Thu, Aug 16, 2012 at 11:34:56AM +0000, Opensource [Anthony Olech] wrote:

Fix your mail configuration to word wrap at something less than 80
columns within paragraphs, your mails are currently extremely hard to
read.

> The only other interpretation of your comment is that the h/w IRQ line setup code must be done
> in the machine driver, in my case for testing is arch/arm/mach-s3c64xx/mach-smdk6410.c
> But that view is contricted by the init call-backs from the wm8350 and wm1192 drivers.

This board driver is not a modern driver, configuration callbacks used
to be used but this is no longer be something that's needed.

> I am confused, but it does make sense to do the GPIO --> IRQ initialization in the machine driver,
> so I will try to do that. But who would be responsible for changing the wm8350 and wm1192 drivers
> to also follow that philosophy?

If someone has the time and enthusiasm it might be worthwhile, but it's
not clear that this is the case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/