Re: [net V2] act_mirred: do not drop packets when fails to mirrorit

From: Jamal Hadi Salim
Date: Thu Aug 16 2012 - 08:12:03 EST


On Thu, 2012-08-16 at 14:44 +0800, Jason Wang wrote:
> We drop packet unconditionally when we fail to mirror it. This is not intended
> in some cases. Consdier for kvm guest, we may mirror the traffic of the bridge
> to a tap device used by a VM. When kernel fails to mirror the packet in
> conditions such as when qemu crashes or stop polling the tap, it's hard for the
> management software to detect such condition and clean the the mirroring
> before. This would lead all packets to the bridge to be dropped and break the
> netowrk of other virtual machines.
>
> To solve the issue, the patch does not drop packets when kernel fails to mirror
> it, and only drop the redirected packets.
>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

Signed-off-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/