Re: [PATCH 15/21] net sched: Pass the skb into change so it canaccess NETLINK_CB

From: Jamal Hadi Salim
Date: Wed Aug 15 2012 - 04:20:14 EST


On Mon, 2012-08-13 at 13:18 -0700, Eric W. Biederman wrote:
> From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>
> cls_flow.c plays with uids and gids. Unless I misread that
> code it is possible for classifiers to depend on the specific uid and
> gid values. Therefore I need to know the user namespace of the
> netlink socket that is installing the packet classifiers. Pass
> in the rtnetlink skb so I can access the NETLINK_CB of the passed
> packet. In particular I want access to sk_user_ns(NETLINK_CB(in_skb).ssk).
>
> Pass in not the user namespace but the incomming rtnetlink skb into
> the the classifier change routines as that is generally the more useful
> parameter.
>
> Cc: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>
> Acked-by: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>


Acked-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/