Re: [GIT PULL] gpio fixes for v3.6-rc1

[Linus Walleij]

On Mon, Aug 13, 2012 at 4:36 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday 10 August 2012, Linus Walleij wrote:
>> Daniel Mack (1):
>>       GPIO: gpio-pxa: fix devicetree functions
>>
>
> Unfortunately, this one caused a build regression, see the fix below.
> I also wonder why pxa_irq_domain_ops isn't static.
>
>         Arnd
>
> 8<----
> GPIO: gpio-pxa: fix building without CONFIG_OF
>
> Patch 7212157267 "GPIO: gpio-pxa: fix devicetree functions" added an
> "xlate" function pointer to the irq_domain_ops, but this function
> is nor declared or defined anywhere when CONFIG_OF is disabled, causing
> the build error:
>
> drivers/gpio/gpio-pxa.c:532:11: error: 'irq_domain_xlate_twocell' undeclared here (not in a function)
>
> Extending the DT-only code section to cover the irq_domain_ops
> and the pxa_gpio_dt_ids solves this problem and makes it clearer
> which code is actually used without DT.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks, applied this to my fixes branch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/