Re: [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for registeraccess protection

[Feng Tang]

On Mon, 13 Aug 2012 14:01:31 +0200
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Sun, Jul 29, 2012 at 4:54 AM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> 
> > gpio_chip.can_sleep is 0, but current code uses mutex in ioh_gpio_set,
> > ioh_gpio_get and ioh_gpio_direction_input functions.
> > Thus those functions are not callable from interrupt context.
> > This patch converts mutex into spinlock.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> 
> So IOH guys what are you saying about this?

I'm not the IOH guy, but just happened to work on it for some time :) Anyway,
the 2 patches both look good to me.

Thanks,
Feng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/