Re: [PATCH 2/2] apple_gmux: Add support for newer hardware

[Seth Forshee]

On Mon, Aug 13, 2012 at 04:20:32PM -0400, Matthew Garrett wrote:
> +static int gmux_index_wait_ready(struct apple_gmux_data *gmux_data)
> +{
> +	int i = 200;
> +	u8 gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE);
> +
> +	while (i && (gwr & 0x01)) {
> +		inb(gmux_data->iostart + GMUX_PORT_READ);
> +		gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE);
> +		msleep(100);

Wouldn't it make more sense if the msleep was before reading the port
again? Otherwise there's no substantial dely between the first and
second times we read it.

> +static int gmux_index_wait_complete(struct apple_gmux_data *gmux_data)
> +{
> +	int i = 200;
> +	u8 gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE);
> +
> +	while (i && (gwr & 0x01)) {
> +		gwr = inb(gmux_data->iostart + GMUX_PORT_WRITE);
> +		msleep(100);

Likewise.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/