RE: [PATCH] drivers: hv: use Linux version in guest ID

From: KY Srinivasan
Date: Mon Aug 13 2012 - 09:04:43 EST




> -----Original Message-----
> From: BjÃrn Mork [mailto:bjorn@xxxxxxx]
> Sent: Monday, August 13, 2012 9:00 AM
> To: Greg KH
> Cc: KY Srinivasan; Paolo Bonzini; devel@xxxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] drivers: hv: use Linux version in guest ID
>
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> > On Fri, Jul 20, 2012 at 04:02:44PM +0000, KY Srinivasan wrote:
> >> > On Fri, Jul 20, 2012 at 10:03:08AM +0200, BjÃrn Mork wrote:
> >> >
> >> > > +/* Linux vendor ID allocated by Microsoft */
> >> > > +#define HV_LINUX_GUEST_ID_VENDOR 0xB16B
> >> > > +
> >> > > +/* Creating a guest ID conforming to the encoding recommended by
> >> > > + * Microsoft, with variant and build fixed to 0
> >> >
> >> > We could use the kernel build number here as well, if we really wanted
> >> > it, right?
>
> Yes, we could. I just didn't see any value it that. Why would you want
> your hypervisor to care about some arbitrary build number?
>
> But it can of course be added if anyone needs it.
>
> >> > Otherwise, I like this patch, KY, any objection to me taking it?
> >>
> >> Greg,
> >>
> >> If it is ok with you can we wait a couple of days. I am pushing to get
> information
> >> back from folks within MSFT. I am hoping we can fix this issue soon.
> >
> > Ok, I'll hold on to it for a week or so.
>
> Not to nag or anything like that, but ... It's been a week or so now,
> hasn't it? :-)

In the interim, I have submitted a patch that conforms to the MSFT guidelines
for generating guest IDs for non-MSFT operating systems on Hyper-V.

Regards,

K. Y
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i