Re: [PATCH 12/41] mxser: allow overlapping vector

[Jiri Slaby]

On 08/13/2012 03:50 AM, Rusty Russell wrote:
> On Tue,  7 Aug 2012 21:47:37 +0200, Jiri Slaby <jslaby@xxxxxxx> wrote:
>> For many cards, this saves some IO space because interrupt status port
>> has precedence over the rest of ports on the card. Hence it can be
>> mapped to a hole in I/O ports.
>>
>> Here we add a kernel parameter which allows that if a user wants to.
>> But they need to explicitly enable it by a module parameter.
>>
>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
>> ---
>>  drivers/tty/mxser.c |   35 +++++++++++++++++++++++++++++++----
>>  1 file changed, 31 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
>> index c162ee9..e64fe40 100644
>> --- a/drivers/tty/mxser.c
>> +++ b/drivers/tty/mxser.c
>> @@ -2337,11 +2337,36 @@ static struct tty_port_operations mxser_port_ops = {
>>   * The MOXA Smartio/Industio serial driver boot-time initialization code!
>>   */
>>  
>> +static bool allow_overlapping_vector;
>> +module_param(allow_overlapping_vector, bool, 444);
> 
> You mean 0444, right?

Of course I did. I wonder why patch posters like numbers instead of
names. I will change this to S_IRUGO.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/