Re: [PATCH 1/6] ARM: dove: unify clock setup

[Sebastian Hesselbarth]

On 08/11/2012 11:12 AM, Andrew Lunn wrote:
> > +	/* Ensure tclk is always clocked */
> > +	clk_prepare_enable(tclk);
> >   }
>
> "ticking" would be better than clocked.
>
> Since this is a root fixed clock, is it necessary to prepare_enable()
> it? I think prepare and enable become NOPs in this situation.

Hi Andrew,

yes you are right, it is useless to prepare or enable a fixed rate clk.
I cannot be gated anyway. I'll update the patch and resend soon.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/