Re: [Intel-gfx] [PATCH] drm/i915: ingore eDP bpc settings

[Paul Menzel]

Am Freitag, den 10.08.2012, 11:10 +0200 schrieb Daniel Vetter:

There is a typo in the commit summary: i*gn*ore.

> This has originally been introduced to not oversubscribe the dp links
> in
> 
> commit 885a5fb5b120a5c7e0b3baad7b0feb5a89f76c18
> Author: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> Date:   Tue Jan 12 05:38:31 2010 +0800
> 
>     drm/i915: fix pixel color depth setting on eDP
> 
> Since then we've fixed up the dp link bandwidth calculation code for
> code

`for code` should be removed.

> and should now automatically fall back to 6bpc dithering. So this
> is unnecessary.
> 
> Furthermore it seems to break the new MacbookPro with retina display,
> hence let's just rip this out.
> 
> Reported-by: Benoit Gschwind <gschwind@xxxxxxxxxxx>
> Cc: Benoit Gschwind <gschwind@xxxxxxxxxxx>
> Cc: Francois Rigaut <frigaut@xxxxxxxxx>
> Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> 
> --
> 
> Testing feedback highgly welcome, and thanks for Benoit for finding
> out that the bpc computations are busted.
> -Daniel
> ---
>  drivers/gpu/drm/i915/intel_display.c |   11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index bddb290..ddd4db3 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3755,17 +3755,6 @@ static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc,
>  			continue;
>  		}
>  
> -		if (intel_encoder->type == INTEL_OUTPUT_EDP) {
> -			/* Use VBT settings if we have an eDP panel */
> -			unsigned int edp_bpc = dev_priv->edp.bpp / 3;
> -
> -			if (edp_bpc < display_bpc) {
> -				DRM_DEBUG_KMS("clamping display bpc (was %d) to eDP (%d)\n", display_bpc, edp_bpc);
> -				display_bpc = edp_bpc;
> -			}
> -			continue;
> -		}
> -
>  		/* Not one of the known troublemakers, check the EDID */
>  		list_for_each_entry(connector, &dev->mode_config.connector_list,
>  				    head) {

Acked-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part