Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean

From: Andi Kleen
Date: Fri Aug 10 2012 - 19:08:38 EST


Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> writes:

> action_result() fails to print out "dirty" even if an error occurred on a
> dirty pagecache, because when we check PageDirty in action_result() it was
> cleared after page isolation even if it's dirty before error handling. This
> can break some applications that monitor this message, so should be fixed.
>
> There are several callers of action_result() except page_action(), but
> either of them are not for LRU pages but for free pages or kernel pages,
> so we don't have to consider dirty or not for them.

Looks good

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>


-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/