Re: [PATCH] usb: host: tegra: fix warning messages in ehci_remove

[Alan Stern]

On Fri, 10 Aug 2012, Venu Byravarasu wrote:

> Existing implementation of tegra_ehci_remove() calls
> usb_put_hcd(hcd) first and then iounmap(hcd->regs).
> 
> usb_put_hcd() implementation calls hcd_release()
> which frees up memory allocated for hcd.
> 
> As iounmap is trying to unmap hcd->regs, after hcd
> getting freed up, warning messages were observed during
> unload of USB.
> 
> Hence fixing it.
> 
> Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
> ---
>  drivers/usb/host/ehci-tegra.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 950e95e..26dedb3 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -799,11 +799,12 @@ static int tegra_ehci_remove(struct platform_device *pdev)
>  #endif
>  
>  	usb_remove_hcd(hcd);
> -	usb_put_hcd(hcd);
>  
>  	tegra_usb_phy_close(tegra->phy);
>  	iounmap(hcd->regs);
>  
> +	usb_put_hcd(hcd);
> +
>  	clk_disable_unprepare(tegra->clk);
>  	clk_put(tegra->clk);

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/