Re: [patch] mmap: feed back correct prev vma when finding vma

From: Hillf Danton
Date: Fri Aug 10 2012 - 08:00:22 EST


On Fri, Aug 10, 2012 at 9:26 AM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> On Thu, 9 Aug 2012, Hillf Danton wrote:
>> After walking rb tree, if vma is determined, prev vma has to be determined
>> based on vma; and rb_prev should be considered only if no vma determined.
>
> Why? Because you think more code is better code? I disagree.

s/more/correct/

Because feedback is incorrect if we return vma corresponding to
the root node.

Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/