Re: [lm-sensors] NULL dereference BUG in sch56xx_init()

From: Hans de Goede
Date: Fri Aug 10 2012 - 04:35:34 EST


Hi,

On 08/09/2012 04:42 PM, Guenter Roeck wrote:
On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote:
Hi Guenter,

This commit triggered an oops which can be fixed by the attached diff.
Should it be folded into the original one (preferable for me), or be
resent as a standalone patch?

I folded it into the original commit.

Thanks a lot for the test and feedback!

Fengguang, good catch, thanks!

Guenter, 2 remarks:

1) The changing of the type of the address parameter of sch56xx_device_add is
not necessary
2) A similar change is needed for the f71882fg, there the type of the address
variable in f71882fg_init() needs to be changed to int too.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/