Re: [PATCH v5 02/12] KVM: hide KVM_MEMSLOT_INVALID from userspace

From: Xiao Guangrong
Date: Thu Aug 09 2012 - 22:11:58 EST


On 08/10/2012 02:48 AM, Marcelo Tosatti wrote:

>> +#define KVM_MEMSLOT_INVALID (1UL << 31)
>> +
>> /*
>> * If we support unaligned MMIO, at most one fragment will be split into two:
>> */
>
> Please document which range is for userspace visible flags, which range
> is reserved. Mention that in both headers, point to each other
> ("userspace definitions are there" / "internal definitions are there").
>
> 16/16 bits for each should be fine.

Okay, good to me, will do it in the next version, thank you, Marcelo!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/