Re: [BUG] perf: sharing of cpuctx between core and ibs PMU causes problems

From: Stephane Eranian
Date: Thu Aug 09 2012 - 15:21:28 EST


On Thu, Aug 9, 2012 at 8:08 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Thu, 2012-08-09 at 16:05 +0200, Stephane Eranian wrote:
>> > uncore PMU does not have this issue because uncore_pmu->task_ctx_nr
>> > is 'perf_invalid_context'. find_pmu_context() always return NULL in
>> > that case.
>> >
>> Yes, I think IBS should do the same and that should fix the problem
>> there too. Will try that.
>
> I'm afraid not, per-task profiling with uncore doesn't really make that
> much sense. For IBS it does.
>
> We can't share a context with different PMUs, that'll totally mess up
> the event scheduling.
>
> We'll have to grow perf_event_task_context with an extra context and
> have IBS use that.

Ok, I am fine with that. Don't know about to call it though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/