Re: [PATCH 2/2 v2] ALSA: hda - Deferred probing withrequest_firmware_nowait()

[Thierry Reding]

On Thu, Aug 09, 2012 at 03:54:04PM +0200, David Henningsson wrote:
> On 08/09/2012 03:36 PM, Takashi Iwai wrote:
> >+/* callback from request_firmware_nowait() */
> >+static void azx_firmware_cb(const struct firmware *fw, void *context)
> >+{
> >+	struct snd_card *card = context;
> >+	struct azx *chip = card->private_data;
> >+	struct pci_dev *pci = chip->pci;
> >+
> >+	if (!fw) {
> >+		snd_printk(KERN_ERR SFX "Cannot load firmware, aborting\n");
> >+		goto error;
> >+	}
> 
> Another thing, aren't you missing a
> 
> chip->fw = fw;
> 
> here?

Adding that line here fixes the problem for me.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature