Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree

From: Catalin Marinas
Date: Thu Aug 09 2012 - 04:32:57 EST


On Wed, Aug 08, 2012 at 06:07:39PM +0100, Michel Lespinasse wrote:
> kmemleak uses a tree where each node represents an allocated memory object
> in order to quickly find out what object a given address is part of.
> However, the objects don't overlap, so rbtrees are a better choice than
> prio tree for this use. They are both faster and have lower memory overhead.
>
> Tested by booting a kernel with kmemleak enabled, loading the kmemleak_test
> module, and looking for the expected messages.
>
> Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx>

The patch looks fine to me but I'll give it a test later today and let
you know.

--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/