Re: [PATCH v5 5/5] perf script: Add event_analyzing_sample.py as asample for general event handling

[Feng Tang]

On Thu, 9 Aug 2012 14:19:29 +0900
Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> Hi,
> 
> On Thu, 9 Aug 2012 12:30:07 +0800, Feng Tang wrote:
> > Hi Namhyung,
> >
> > Many thanks for your valuable comments, I'll fold the fixes into an
> > incremental patch.
> >
> > On Thu, 9 Aug 2012 10:30:34 +0900
> > Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> >> On Wed,  8 Aug 2012 17:57:55 +0800, Feng Tang wrote:
> >> > Currently only trace point events are supported in perf/python script,
> >> > the first 3 patches of this serie add the support for all types of
> >> 
> >
> >> > +con = sqlite3.connect("/dev/shm/perf.db")
> >> > +con.isolation_level = None
> >> > +
> >> > +def trace_begin():
> >> > +	print "In trace_begin:\n"
> >> 
> >> It seems it's not aligned with other statements, and even not needed at
> >> all. Does it work?
> >
> > trace_begin() is a must have for a python script, the <print "In
> > trace_begin:\n"> is automatically generated from "perf script -g", I guess
> > its intension is to help developer debug their own patches. and same for
> > the trace_end().
> >
> I meant the print statement not trace_begin function :)

I see

> 
> Btw, by any chance do you plan to add support to callchains? I think
> it's very nice to have.

No, it's not on the plan list :). My next plan is to integrate the perf
script to the perf report framework, so that users can directly call
perf script inside perf report browser like running the annotation.

Thanks,
Feng

> 
> Thanks,
> Namhyung
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/