Re: [PATCH 2/5] x86/uprobes: implement x86 specificarch_uprobe_*_step
From: Ananth N Mavinakayanahalli
Date: Thu Aug 09 2012 - 00:43:59 EST
On Wed, Aug 08, 2012 at 04:53:45PM +0200, Oleg Nesterov wrote:
> On 08/08, Sebastian Andrzej Siewior wrote:
...
> >> ->insn[0] doesn't look right, we should skip the prefixes.
insn_init()
insn_get_opcode()
if (OPCODE1() == 0x9d)
is always the right way of doing it.
...
> And in any case it would be better to re-use auprobe->fixups.
Agreed.
Ananth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/