Re: [PATCH 02/41] TTY: 68328serial, fix compilation

From: Alan Cox
Date: Wed Aug 08 2012 - 11:07:47 EST


On Tue, 7 Aug 2012 21:47:27 +0200
Jiri Slaby <jslaby@xxxxxxx> wrote:

> tty_struct->termios is no longer a pointer. This was changed recently
> by "tty: move the termios object into the tty". But 68328serial was
> not changed, so we now have a compilation error:
> 68328serial.c: In function 'change_speed':
> 68328serial.c:518:22: error: invalid type argument of '->' (have
> 'struct ktermios') 68328serial.c: In function 'rs_set_ldisc':
> 68328serial.c:620:31: error: invalid type argument of '->' (have
> 'struct ktermios') 68328serial.c: In function 'rs_set_termios':
> 68328serial.c:988:20: error: invalid type argument of '->' (have
> 'struct ktermios')
>
> Fix that now.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxx>

Cool - I couldn't even find a compile chain or config to test this. I'd
assumed it was broken and really wanted dumping in staging (it still
looks that way 8))

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/