[PATCH v5 09/19] vfs: fix mkdir to retry on ESTALE errors

From: Jeff Layton
Date: Wed Aug 08 2012 - 09:26:00 EST


Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
---
fs/namei.c | 29 +++++++++++++++++++----------
1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 0a0397f..9fd5163 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3190,17 +3190,26 @@ SYSCALL_DEFINE3(mkdirat, int, dfd, const char __user *, pathname, umode_t, mode)
struct dentry *dentry;
struct path path;
int error;
+ char *name;
+ unsigned int try = 0;

- dentry = user_path_create(dfd, pathname, &path, 1);
- if (IS_ERR(dentry))
- return PTR_ERR(dentry);
-
- if (!IS_POSIXACL(path.dentry->d_inode))
- mode &= ~current_umask();
- error = security_path_mkdir(&path, dentry, mode);
- if (!error)
- error = vfs_mkdir(path.dentry->d_inode, dentry, mode);
- done_path_create(&path, dentry);
+ name = getname(pathname);
+ if (IS_ERR(name))
+ return PTR_ERR(name);
+ do {
+ dentry = kern_path_create(dfd, name, &path, true, try);
+ if (IS_ERR(dentry)) {
+ error = PTR_ERR(dentry);
+ break;
+ }
+ if (!IS_POSIXACL(path.dentry->d_inode))
+ mode &= ~current_umask();
+ error = security_path_mkdir(&path, dentry, mode);
+ if (!error)
+ error = vfs_mkdir(path.dentry->d_inode, dentry, mode);
+ done_path_create(&path, dentry);
+ } while (retry_estale(error, try++));
+ putname(name);
return error;
}

--
1.7.11.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/