Re: [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

[Sebastian Andrzej Siewior]

On 08/08/2012 02:57 PM, Oleg Nesterov wrote:
> > +static int insn_changes_flags(struct arch_uprobe *auprobe)
> > +{
> > +	/* popf reads flags from stack */
> > +	if (auprobe->insn[0] == 0x9d)
> > +		return 1;
>
> Ah, somehow I didn't think about this before.
>
> ->insn[0] doesn't look right, we should skip the prefixes.

Why? I tried 'lock popf' and I got invalid instruction. The same for
'rep popf'.

> Oleg.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/