Re: [PATCHv3 0/6] perf, tool: Allow to use hw events in PMU syntax

From: Jiri Olsa
Date: Wed Aug 08 2012 - 08:42:27 EST


On Mon, Jul 09, 2012 at 10:37:44PM +0200, Jiri Olsa wrote:
> hi,
> here's the change to make following syntax available:
> perf stat -e cpu/event=instructions/u ls
>
> this is identical to:
> perf stat -e instructions:u ls
>
> v3 changes:
> - patches v2 1,5,6,9 are already in
> - patch 1 - sysfs 'events' attribute file names with dashes '-'
> - using 'event/umask/inv/cmask' terms assigments instead simple 'config'
> - patch 2 - undefined events sysfs attributes filtered out
>
> v2 changes:
> - making the hw events translations available under the 'events',
> the userspace trnaslation is then done by existing term aliasing
> code with some little tweeks ;)
> - patches 1-3 are independent fixies
>
> Attached patches:
> 1/6 perf, x86: Making hardware events translations available in sysfs
> 2/6 perf, x86: Filter out undefined events from sysfs events attribute
> 3/6 perf, tool: Fix pmu object alias initialization
> 4/6 perf, tool: Properly free format data
> 5/6 perf, tool: Add support to specify hw event as pmu event term
> 6/6 perf, test: Add automated tests for pmu sysfs translated events
>
> jirka
> ---
> arch/x86/kernel/cpu/perf_event.c | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/parse-events-test.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++--
> tools/perf/util/parse-events.c | 13 +++++++++
> tools/perf/util/parse-events.h | 2 ++
> tools/perf/util/parse-events.y | 9 ++++++
> tools/perf/util/pmu.c | 59 ++++++++++++++++++++++++---------------
> 6 files changed, 232 insertions(+), 24 deletions(-)

hi,
any feedback on this?
you can check rebased version (on Arnaldo's perf/core) here:

git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git
perf/sysfs_events1

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/