Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

From: Willy Tarreau
Date: Wed Aug 08 2012 - 02:18:22 EST


On Tue, Aug 07, 2012 at 10:58:00PM -0700, David Miller wrote:
> From: Jike Song <albcamus@xxxxxxxxx>
> Date: Wed, 8 Aug 2012 13:50:42 +0800
>
> > On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb <chris@xxxxxxxxxxxx> wrote:
> >> Commit c2c20ef43d00 "bnx2: Update driver to use new mips firmware"
> >> updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of
> >> bnx2-mips-09-6.2.1a, but didn't replace the copy of bnx2-mips-09-6.2.1a
> >> in firmware/bnx2/ with the new version.
> >>
> >> This means that the bnx2 driver stopped working altogether for users who
> >> use CONFIG_FIRMWARE_IN_KERNEL to compile firmware together with drivers
> >> into their kernel, rather than having a runtime firmware loader.
> >>
> >
> > Still not fixed in mainline? I encountered the same problem with
> > v3.6-rc1-133-g42a579a.
>
> The current firmware for all drivers are not distributed in the kernel
> sources any longer, they are maintained in a completely seperate
> repository.
>
> The old ones are just kept around in the kernel sources for
> compatability.
>
> This is a FAQ.

Well, if the drivers provided with the kernel don't work out of the box
anymore, maybe we should also move them to a separate repository. All it
is going to do otherwise is to cause invalid bug reports because users
don't understand why using the latest driver does not work.

That way it would be clear that an in-kernel driver has to be self-sustaining
to be maintainable, otherwise it has nothing to do there.

Just my 2 cents,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/