RE: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver

From: Arun MURTHY
Date: Tue Aug 07 2012 - 23:36:50 EST


> > drivers/modem_shm/Kconfig | 2 +
> > drivers/modem_shm/Makefile | 1 +
> > drivers/modem_shm/u8500_shm/Kconfig | 43 +
> > drivers/modem_shm/u8500_shm/Makefile | 7 +
> > drivers/modem_shm/u8500_shm/shrm_char.c | 895 ++++++++++++
> > drivers/modem_shm/u8500_shm/shrm_driver.c | 732 ++++++++++
> > drivers/modem_shm/u8500_shm/shrm_fifo.c | 837 ++++++++++++
> > drivers/modem_shm/u8500_shm/shrm_net.c | 312 +++++
> > drivers/modem_shm/u8500_shm/shrm_protocol.c | 1590
> ++++++++++++++++++++++
> > include/linux/modem_shm/u8500_shm/shrm.h | 23 +
> > include/linux/modem_shm/u8500_shm/shrm_config.h | 114 ++
> > include/linux/modem_shm/u8500_shm/shrm_driver.h | 225 +++
> > include/linux/modem_shm/u8500_shm/shrm_ioctl.h | 43 +
> > include/linux/modem_shm/u8500_shm/shrm_net.h | 46 +
> > include/linux/modem_shm/u8500_shm/shrm_private.h | 183 +++
>
> Why do any of those .h files need to be in include/linux/*? Shouldn't
> they just be in the same directory as the driver itself?

Can be moved to the same dir. Will do that in the next ver of the patch.

Thanks and Regards,
Arun R Murthy
-------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/