Re: [PATCH] spi: omap2-mcspi: In case of dma errors fall back to pio

From: Felipe Balbi
Date: Tue Aug 07 2012 - 08:25:05 EST


Hi,

On Tue, Aug 07, 2012 at 05:02:27AM -0700, Tony Lindgren wrote:
> * Shubhrajyoti <shubhrajyoti@xxxxxx> [120807 04:21]:
> > On Tuesday 07 August 2012 01:17 PM, Tony Lindgren wrote:
> > >> };
> > > Don't you need to check separately for rx and tx dma? There's a slight
> > > chance that you get a channel for one but not for the other..
> > In that case I treat it as non usable and fall back to pio.
>
> OK that should work too.
>
> > Are you suggesting that let one channel be dma and only the failed one pio?
>
> I guess both are doable. For reduced CPU load using DMA where possible
> of course is the best way to go.

indeed. if you can get DMA for TX but not for RX, then at least TX can
go via DMA ;-)

--
balbi

Attachment: signature.asc
Description: Digital signature