Re: [PATCH v2] power_supply: Added support for power supplyattribute sources

[Anton Vorontsov]

On Fri, Jul 27, 2012 at 06:28:31PM +0000, Pallala, Ramakrishna wrote:
[...]
> > > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>
> > > ---
> > [...]
> > > +extern int power_supply_attributes_register(struct device *parent,
> > > +				struct power_supply_attr_source *psy_attr);
> > 
> > Can you please show some user of the new calls? If I understand correctly,
> > you're going to call these from sensing (ADC, or some
> > other) drivers, which would be very very wrong thing to do.
> 
> I have submitted two patches, one on smb347_charger driver and one on max17042_battery driver
> to demonstrate the use of these API's.
> 
> [PATCH] smb347_charger: Add support for battery power supply attributes registration
> [PATCH] max17042_battery: add support for battery STATUS and CHARGE_TYPE

Yeah, I noticed them, I'll review the whole approach tomorrow.

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/