RE: [PATCH] video: s3c-fb: Fix compile error/warning if CONFIG_OFis not selected

[Dongjin Kim]

Sorry, seems its my bad.

I took couple of commits from linaro kernel git for s3c-fb driver testing on my hardware and encountered the compile problem. Now I got your meaning, DT is not merged yet.

Thanks,
Dongjin.
----- 원본 메시지 -----
보낸 사람:Jingoo Han <jg1.han@xxxxxxxxxxx>
받는 사람:'Dongjin Kim' <tobetter@xxxxxxxxx>
참조:Dongjin Kim <Dongjin.Kim@xxxxxxxxxxxxxxxxxxx>, 'Florian Tobias Schandinat' <FlorianSchandinat@xxxxxx>, "linux-fbdev@xxxxxxxxxxxxxxx" <linux-fbdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, 'Jingoo Han' <jg1.han@xxxxxxxxxxx>
보낸 시간:2012. 8. 7. 9:24 오전
제목:Re: [PATCH] video: s3c-fb: Fix compile error/warning if CONFIG_OF is not selected



On Monday, August 06, 2012 10:58 PM Dongjin Kim wrote:
>
> Change-Id: I5d7ff6f0070a10225d5b064b362d3d8f214787fd
> Signed-off-by: Dongjin Kim <dongjin.kim@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/video/s3c-fb.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 8c8adb5..268be0c 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1527,13 +1527,11 @@ static int s3c_fb_dt_parse_gpios(struct device *dev, struct s3c_fb *sfb,
>
>  static void s3c_fb_dt_free_gpios(struct s3c_fb *sfb)
>  {
> -     return 0;
>  }
>
> -static int s3c_fb_dt_parse_pdata(struct device *dev,
> -                                     struct s3c_fb_platdata **pdata)
> +static struct s3c_fb_platdata *s3c_fb_dt_parse_pdata(struct device *dev)
>  {
> -     return 0;
> +     return NULL;
>  }
>  #endif /* CONFIG_OF */


Um, DT is not yet merged to s3c-fb driver.
s3c_fb_dt_parse_pdata() and s3c_fb_dt_free_gpios() are not available.

So, this patch is unnecessary.

Best regards,
Jingoo Han


>
> --
> 1.7.9.5


N떑꿩ěr¸›y鉉싕b˛XФ푤vŘ^–)頻{.nÇ+돴ĽŠ{ą묎çzX㎍썳變}Š옽Ć zÚ&j:+v돣žŤ묎çzZ+€Ę+zf＂ˇhš닱~넮녬i˙鎬zšŽwⅱ¸?솳鈺Ú&˘)刪f뷌^j푹y§m끷@AŤa뛴˙0띠hŽĺ’i